Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_array_index returns list, instead should be int #279

Closed
bobleesj opened this issue Dec 26, 2024 · 0 comments · Fixed by #283
Closed

get_array_index returns list, instead should be int #279

bobleesj opened this issue Dec 26, 2024 · 0 comments · Fixed by #283
Milestone
3.6.0 release

Comments

@bobleesj
Copy link
Contributor

bobleesj commented Dec 26, 2024 •
edited
Loading

let's check. Logically, this should return an int not a list. Let's check and maybe update the function/tesnts, or understand why it returns a list and change the name.

Originally posted by @sbillinge in #271 (comment)
@bobleesj bobleesj changed the title get_array_index returns list, not should be int get_array_index returns list, instead should be int Dec 26, 2024
@bobleesj bobleesj mentioned this issue Dec 26, 2024
Merged
@bobleesj bobleesj added this to the 3.6.0 release milestone Dec 26, 2024
@bobleesj bobleesj mentioned this issue Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0 release
Development

Successfully merging a pull request may close this issue.

Fix get_array_index returns int instead of list in DiffractionObject bobleesj/diffpy.utils
1 participant
@bobleesj