Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headless to true to doc GitHub build workflow to sudo apt-get install -y xvfb #71

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Dec 6, 2024

The goal of this PR is to ensure we can render API doc strings with our linux CI.

Closes #70 - fixing API docstrings
Closes #18 - build API doc
Closes #33 - fixing doc link

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 6, 2024

@sbillinge ready for review

@cadenmyers13 once this is merged, let's try to deploy the doc from your forked repo and let's see if this works!

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (5a437f2) to head (26be37f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files           4        4           
  Lines         177      177           
=======================================
  Hits          166      166           
  Misses         11       11           

@cadenmyers13
Copy link
Contributor

@bobleesj I made the edits and the API rendered properly 👍 Just add a news item and this should be good to go once reviewed

Screenshot 2024-12-06 at 10 16 33 AM

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 6, 2024

@bobleesj I made the edits and the API rendered properly 👍 Just add a news item and this should be good to go once reviewed

Beautiful!!! Time to finally wrap our release up.

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 6, 2024

news added thanks @cadenmyers13

@sbillinge sbillinge merged commit 2610788 into diffpy:main Dec 7, 2024
5 checks passed
@sbillinge
Copy link
Contributor

Thanks @bobleesj !

@bobleesj bobleesj deleted the doc-build branch December 7, 2024 02:30
@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 7, 2024

@cadenmyers13

@sbillinge deployed the docs by dispatch from main but it appears the API docs are not being rendered.

The screenshot above indeed indicate that you were able to render the API docstrings using this workflow. Could you check if there any difference between your forked fourigui and main?

https://github.com/diffpy/diffpy.fourigui/actions/runs/12209252446

Screenshot 2024-12-06 at 9 50 55 PM

@cadenmyers13
Copy link
Contributor

cadenmyers13 commented Dec 9, 2024

@bobleesj There's no difference in code between my fork and upstream. I sync'd my fork with upstream and that rendered too. Not sure what the issue could be here. Do we need to trigger the build?

@sbillinge
Copy link
Contributor

Could this be the problem maybe?:

WARNING: autodoc: failed to import module 'fourigui' from module 'diffpy.fourigui'; the following exception was raised:
Cannot load backend 'tkagg' which requires the 'tk' interactive framework, as 'headless' is currently running [autodoc.import_object]

@sbillinge
Copy link
Contributor

Maybe we can't build the documentation headless, or we need another workaround? Pls could you look into it?

@cadenmyers13
Copy link
Contributor

@sbillinge Where does this warning come from? Im not getting this warning when i build on my end. I'd like to reproduce locally.

@sbillinge
Copy link
Contributor

That was in the log in the action called docs and then under build documentation. I am not sure what the problem is (and it could be happening at the deploy stage) but I just noticed that error. I don't know if it is the problem. Look here:
https://github.com/diffpy/diffpy.fourigui/actions/runs/12209241804/job/34063721050

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 9, 2024

#73

Please see this new PR, fixing this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Doc not rendering for diffpy.fourigui Fix documentation links in README Build docs with public URL
3 participants