-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add headless to true
to doc GitHub build workflow to sudo apt-get install -y xvfb
#71
Conversation
@sbillinge ready for review @cadenmyers13 once this is merged, let's try to deploy the doc from your forked repo and let's see if this works! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 4 4
Lines 177 177
=======================================
Hits 166 166
Misses 11 11 |
@bobleesj I made the edits and the API rendered properly 👍 Just add a news item and this should be good to go once reviewed |
Beautiful!!! Time to finally wrap our release up. |
news added thanks @cadenmyers13 |
Thanks @bobleesj ! |
@sbillinge deployed the docs by dispatch from The screenshot above indeed indicate that you were able to render the API docstrings using this workflow. Could you check if there any difference between your forked fourigui and https://github.com/diffpy/diffpy.fourigui/actions/runs/12209252446 |
@bobleesj There's no difference in code between my fork and upstream. I sync'd my fork with upstream and that rendered too. Not sure what the issue could be here. Do we need to trigger the build? |
Could this be the problem maybe?:
|
Maybe we can't build the documentation headless, or we need another workaround? Pls could you look into it? |
@sbillinge Where does this warning come from? Im not getting this warning when i build on my end. I'd like to reproduce locally. |
That was in the log in the action called docs and then under build documentation. I am not sure what the problem is (and it could be happening at the deploy stage) but I just noticed that error. I don't know if it is the problem. Look here: |
Please see this new PR, fixing this problem. |
The goal of this PR is to ensure we can render API doc strings with our linux CI.
Closes #70 - fixing API docstrings
Closes #18 - build API doc
Closes #33 - fixing doc link