Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove .coveragerc file #58

Merged
merged 3 commits into from
Nov 7, 2024
Merged

remove .coveragerc file #58

merged 3 commits into from
Nov 7, 2024

Conversation

cadenmyers13
Copy link
Contributor

@cadenmyers13 cadenmyers13 commented Nov 7, 2024

closes #57. With tests at top level, we no longer need to omit any files as pytest automatically detects files in tests. Billingegroup/cookiecutter#177 (comment)

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (4c40b78) to head (38afb09).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #58       +/-   ##
===========================================
+ Coverage   69.85%   93.49%   +23.63%     
===========================================
  Files           3        4        +1     
  Lines         345      169      -176     
===========================================
- Hits          241      158       -83     
+ Misses        104       11       -93     

see 7 files with indirect coverage changes

@cadenmyers13
Copy link
Contributor Author

cadenmyers13 commented Nov 7, 2024

This isn't passing after I made a second push, similar to the other PR here #55

Edit: Looks like this is an active issue faced by others. I've created an issue for this. Solution is being worked out here but will look into this: codecov/codecov-action#1580

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is better without a news. Delete the news.

@sbillinge
Copy link
Contributor

@cadenmyers13 also, this is failing tests. Some issue with codecov

Copy link

github-actions bot commented Nov 7, 2024

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

@cadenmyers13
Copy link
Contributor Author

cadenmyers13 commented Nov 7, 2024

@sbillinge Yeah... there's a github thread here discussing it: codecov/codecov-action#1580

@sbillinge
Copy link
Contributor

Thanks @cadenmyers13

Looks like the codecov problem is resolved too!

@sbillinge sbillinge merged commit 46c65be into diffpy:main Nov 7, 2024
4 of 5 checks passed
@cadenmyers13 cadenmyers13 deleted the coveragerc branch November 28, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove .coveragerc (no longer needed with our cookiecutter setup)
2 participants