-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflow for GitHub releases #2189
Conversation
Some Gradle tasks that were added for printing release notes and performing related actions may now be removed. Please check them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, this has been bothering me for a while. I didn't realize it was as easy as gh release create
, but actually that makes sense that github actions has that already logged in.
The logic here is pretty complex. I might be misunderstanding, but it looks like we would want prerelease
to true for ffurrer2/extract-release-notes
? EDIT: I see from your example that it is already tested, so it must be right I guess
But either way, seems like a better approach is just for this task to call gh blah
?
Maybe the API should look like this?
spotlessChanglog {
afterPushExec "gh release create {{tag}} --title plugin-gradle --notes '{{unreleased}}'"
}
|
I just filed a new issue about the third part to diffplug/spotless-changelog#49. |
This reverts commit 3295ea4.
Thank you for lighting this fire, with the resolution in we can now use for details. |
Check the release results at: