fix: font selection regression #2747
Open
+126
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This recent change #2640 appears to have caused a regression where the first font used in a line of text is utilized for the entire line. This includes usage of
fontFamily
,fontWeight
, andfontStyle
.Changes
pickFontFromFontStack
to select fromfontStack
beforelastFont
. This should now properly prioritize fontspackages/layout/tests/text/fontSubstitution.test.js
Related
Example
Before
After