fix: rendering of \xc2\xa9 copyright symbol #2645
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
specialCases
inpackages/layout/src/text/emoji.js
only ignores the copyright symbol\xc2\xa9\xef\xb8\x8f
and not the standard UTF-8 copyright symbol\xc2\xa9
. The former has the VS-16 variation selector appended to the standard symbol, but the latter still appears to be treated as an emoji and doesn't render.This PR simply adds the standard copyright symbol
\xc2\xa9
to thespecialCases
array along with some comments explaining why there appears to be two copyright symbols.Before the fix:
After the fix: