Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multiple music channels #2427

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

salianifo
Copy link
Contributor

Supersedes #2426

This PR adds the ability to specify what music channel to play on in the Music event. Adds a settings page for Audio with only one setting (max music channels). I made sure to code in backwards compatibility (will play on the first channel).

I would appreciate any feedback, as well as some testing to make sure everything works correctly.

@Jowan-Spooner Jowan-Spooner added the Approved This can be added, but is not on any roadmap yet label Oct 15, 2024
@zaknafean zaknafean self-requested a review October 16, 2024 14:11
Copy link
Collaborator

@zaknafean zaknafean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I love the functionality.

The timelines do break if the channel setting is adjusted and called for. I'd like to see some error handling around 287 in the linked image to avoid that if at all possible. Otherwise we're good to go

image

@salianifo salianifo requested a review from zaknafean October 16, 2024 20:28
@salianifo
Copy link
Contributor Author

Added a check to the is_music_player_resource function that you requested, plus some error info in the update_music function, and a note to the Audio settings that lowering the max channels may invalidate existing music events.

Copy link
Collaborator

@zaknafean zaknafean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'm satisfied with this! It's as protected from bad decisions as it can be! Approved and merging

@zaknafean zaknafean merged commit 11de41c into dialogic-godot:main Oct 16, 2024
2 checks passed
@salianifo salianifo deleted the music-channels branch October 16, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved This can be added, but is not on any roadmap yet
Development

Successfully merging this pull request may close these issues.

3 participants