Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag dtl and dch files with their resource class #2405

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

iscke
Copy link
Contributor

@iscke iscke commented Sep 17, 2024

(this makes them visible to quick load, should fix #2226)

@Jowan-Spooner
Copy link
Member

Hey @iscke, thanks you so much for this, this sounds awesome!

@Jowan-Spooner
Copy link
Member

I like this, but I'd need someone to test if this actually works, e.g @zaknafean.

@zaknafean
Copy link
Collaborator

Testing out PR #2405 is good! The UI for Timeline COULD get a bit wild, but its a great and simple QoL.

NVIDIA_Share_UHnnev5w8y.mp4

Cons:
UI gets a bit annoying to deal with when you have alot of timelines. I think this is more a godot issue rather than an implementation. I do not believe that should prevent merging at this time.

Godot_v4.3-stable_win64_jAhe9JXW83.mp4

@zaknafean zaknafean added the Approved This can be added, but is not on any roadmap yet label Oct 15, 2024
@zaknafean zaknafean self-requested a review October 16, 2024 14:01
Copy link
Collaborator

@zaknafean zaknafean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully tested, and a good QoL for everyone involved. Should merge!

@zaknafean zaknafean merged commit 880a3e2 into dialogic-godot:main Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved This can be added, but is not on any roadmap yet UI/UX ✏
Development

Successfully merging this pull request may close these issues.

Cannot quick load DialogicCharacter .dch custom resource file
3 participants