Fix report generation with missing results

dflook · Sep 27, 2023 · b9a961d · b9a961d
1 parent 2b85ff1
commit b9a961d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/.github/workflows/test_corpus.yaml b/.github/workflows/test_corpus.yaml
@@ -72,8 +72,8 @@ jobs:
  VERSION=0.0.0
  sed -i "s/setup_requires=.*/version='$VERSION',/; s/use_scm_version=.*//" python-minifier/setup.py
  
- if ! pip${{ matrix.python }} install python-minifier/ 2> >(tee -a stderr.log >&2) then;
- if grep -q "requires a different Python" stderr.log; then
+ if ! pip${{ matrix.python }} install python-minifier/ 2> >(tee -a stderr.log >&2); then
+ if grep -q "require a different python version" stderr.log; then
  echo "${{ matrix.ref }} doesn't support Python ${{ matrix.python }}. Skipping."
  echo "skip=true" >> "$GITHUB_OUTPUT"
  else

diff --git a/corpus_test/generate_report.py b/corpus_test/generate_report.py
@@ -257,7 +257,11 @@ def report_larger_than_base(results_dir: str, python_versions: str, minifier_sha
  except FileNotFoundError:
  continue
 
- base_summary = result_summary(results_dir, python_version, base_sha)
+ try:
+ base_summary = result_summary(results_dir, python_version, base_sha)
+ except FileNotFoundError:
+ continue
+
  larger_than_original = sorted(summary.compare_size_increase(base_summary), key=lambda result: result.original_size)[:10]
 
  for entry in larger_than_original:
@@ -275,7 +279,10 @@ def report_slowest(results_dir: str, python_versions: str, minifier_sha: str) ->
 |--------------|--------------:|--------------:|-----:|'''
 
  for python_version in python_versions:
- summary = result_summary(results_dir, python_version, minifier_sha)
+ try:
+ summary = result_summary(results_dir, python_version, minifier_sha)
+ except FileNotFoundError:
+ continue
 
  for entry in sorted(summary.entries.values(), key=lambda entry: entry.time, reverse=True)[:10]:
  yield f'| {entry.corpus_entry} | {entry.original_size} | {entry.minified_size} | {entry.time:.3f} |'