Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add 22 themes #23

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

✨ Add 22 themes #23

wants to merge 9 commits into from

Conversation

metalelf0
Copy link

Here are some themes I wrote or translated from other terminal themes in the last months. Hope you like ;)

@dexpota dexpota self-assigned this Jan 31, 2020
Copy link
Owner

@dexpota dexpota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and I am sorry for the delay.

The review is mostly about the format of the header comment and the licensing information missing. If you can find that information please add it (if not it's not a problem.)

About the comment format, I am trying to introduce a little bit of structure to the themes so it can be easy to inspect them. TBD is a tool to help me and the contributors to format the themes correctly (author and licensing, fields order, etc..)

@@ -0,0 +1,30 @@
# BlackMetal by metalelf0, https://github.com/metalelf0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any licensing information would you like to add?

@@ -0,0 +1,20 @@
# Corvine by arzg, https://github.com/arzg/vim-corvine
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have any licensing information please add them below, from the GitHub repository I can see a LICENSE file. In this case, you could add these lines below:

# This work is licensed under the ISC License.
# For a copy, see https://github.com/arzg/vim-corvine/raw/master/LICENSE

@@ -0,0 +1,21 @@
# DesertNight by sainnhe
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have any licensing information please add them below.

@@ -0,0 +1,46 @@
# GruvboxMaterial theme by sainnhe
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have any licensing information please add them below.

@@ -0,0 +1,46 @@
# GruvboxMaterial theme by sainnhe
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have any licensing information please add them below.

# Kitty snow colors - dark
# Just copy the contents into your kitty config file

# Michael Chris Lopez (http://github.com/mcchrish)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this line to the top and change its format, if available add licensing information.

# Snow Dark by Michael Chris Lopez, http://github.com/mcchrish
# [Licensing if any]

# Kitty snow colors - light
# Just copy the contents into your kitty config file

# Michael Chris Lopez (http://github.com/mcchrish)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in SnowDark.conf.

@@ -0,0 +1,44 @@
### srcery_kitty.conf
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change these lines to have the same format as the others.

# Srcery by srcery-colors, https://github.com/srcery-colors
# [Licensing information if any]

@@ -0,0 +1,25 @@
# Based on nightfly vim colorscheme by @bluz71
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Based on https://github.com/bluz71/vim-nightfly-guicolors  by bluz71
# Licensed under the terms of the MIT license.
# For a copy, see https://opensource.org/licenses/MIT.

@@ -0,0 +1,40 @@
# Drop these into your kitty.conf
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# sourcerer by xero harrison, http://sourcerer.xero.nu
# [Licensing information if any]

# Based on sorcerer by Jeet Sukumaran (http://jeetworks.org)
# & mustang by Henrique C. Alves <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants