Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent a potential race condition that can cause self assignments to be replaced #148

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ghostdogpr
Copy link
Collaborator

@ghostdogpr ghostdogpr commented Oct 30, 2024

If the pod calls getAssignments from the Shard Manager at the same time as assign being called on that pod, we could end up overriding the assigned shards with an old value. We only want to replace all assignments on startup, otherwise we keep self assignments.

@ghostdogpr ghostdogpr merged commit 8cfd314 into series/2.x Oct 30, 2024
5 checks passed
@ghostdogpr ghostdogpr deleted the fix-assignments branch October 30, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants