Add container image #41
Conversation
README.md
Outdated
|
|
||
| To use the container image you first have to build it. | ||
| This assumes you have `docker` installed on your system. | ||
| In case you have setup your Artifactory with self-signed certificates, place all certificates of the chain of trust into the `container/certificates/` folder. |
There was a problem hiding this comment.
Any details should be placed after "common usage" section, the first thing people want to see - a bash command how to run the docker.
Let's move self-signed certificated info to the bottom of this section
container/certificates/ shouldn't it be docker/certificates?
It there a way how to add these certificates in docker run command not in build? It'd be better
- certificates are now installed during container start, not in build step - renamed "destroy mode" env variable to ARTIFACTORY_DESTROY_MODE_ENABLED - rearranged README.md file Changes to be committed: modified: README.md modified: docker/Dockerfile modified: docker/run.sh
|
@DrackThor thank you! I'm going to adjust Dockerfile a bit, I think we should install artifactory-cleanup from the current directory, not pypi. |
|
Docker image was released! @DrackThor thank you for your patience and efforts! |
I've split the old PR #39 into two new PRs, this one contains the Docker image - #40 contains the HELM chart.
Maybe we need to sort out some merge conflicts in the README.md since I've modified it in both PRs.
This image installs a specific version of
artifactory-cleanup, handed to the image as the build argumentVERSION.A little bash script is executed at startup to check if all necessary information is provided, this then also starts
artifactory-cleanupFeedback is most welcome! 😄