-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make source code buildable on macOS #342
Conversation
@JulesMoorhouse @honghaoz hey! First of all, thanks for taking your time to fix this issue - it's been bugging me for a while and getting SwiftUI canvas back would be awesome ✨ Will you have some time soon to take a look at the failing action? I just added the forked version to my project and seems to be fine 🤞 |
Hello @Zandor300 Can you please merge this PR? |
@Archish27 Hi I have just updated the PR. I hope we can merge this change sooner. 🙇 |
@Zandor300 Thanks for triggering the build. However, it seems like danger action failed because it couldn't find commit
From the checkout action:
The head is Looks like the checkout action only fetched the last commit ( Maybe we need to adjust the checkout action fetch more history? or maybe the danger action should smartly use the merging commit. |
@honghaoz @NoemiRozpara @Archish27 |
@Zandor300 I just tried it out, unfortunately, both the
|
@Zandor300 Here is a followup PR (#379) based on the latest master branch. |
Closes this PR in favor of #379 |
tbh, since the library doesn't support macOS, it seems unnecessary to include the code for macOS. unless we decided to include Macs. |
@Zandor300 Here is an example project shows the issue: DeviceKit-Mac.zip. I tested on Xcode 15.2. |
This PR updates the package buildable on macOS, to address the SwiftUI preview issue on macOS, see #341