Skip to content

Commit

Permalink
FIX file size fixed if > 2GB; New setting that allows use file size f…
Browse files Browse the repository at this point in the history
…rom S3 instead of size saved in Frappe File; Safer response check
  • Loading branch information
developmentforpeople committed Jan 19, 2024
1 parent dab1b34 commit e3a3a53
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Shows all files in bucket, even the ones not in Frappe File doctype.

Choose the best setup for you: S3 only for all site files or specified folders, use S3 / Minio presigned urls, cache or not small files, etc.

![Settings](https://github.com/developmentforpeople/dfp_external_storage/assets/47140294/879bbdc9-d356-497e-ac7a-da6e10c6a138)
![Settings](https://github.com/developmentforpeople/dfp_external_storage/assets/47140294/0ad2f24b-d37d-4882-80c4-c1e77a74f666)


## Requirements
Expand Down Expand Up @@ -68,6 +68,7 @@ Choose the best setup for you: S3 only for all site files or specified folders,
- Presigned url activation
- Presigned url only for mimetypes defined
- Presigned url expiration
- Use S3 file size instead of saved on Frappe File (needed for files > 2GB)
- ... maybe I am forgetting something ;)


Expand Down
2 changes: 1 addition & 1 deletion dfp_external_storage/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@

__version__ = '1.1.0'
__version__ = '1.1.1'

3 changes: 3 additions & 0 deletions dfp_external_storage/change_log/v1/v1_1_1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Updates detailed

- New setting that allows using S3 object file size instead of size saved in Frappe File DocType. Needed for files bigger than 2GB.
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"presigned_url_expiration",
"presigned_mimetypes_starting",
"column_break_clee",
"html_mtku",
"remote_size_enabled",
"html_mtku",
"stream_buffer_size",
"cache_files_smaller_than",
"cache_expiration_secs"
Expand Down Expand Up @@ -217,7 +217,7 @@
"link_fieldname": "dfp_external_storage"
}
],
"modified": "2024-01-18 23:00:32.955603",
"modified": "2024-01-19 09:41:51.220454",
"modified_by": "Administrator",
"module": "DFP External Storage",
"name": "DFP External Storage",
Expand Down

0 comments on commit e3a3a53

Please sign in to comment.