Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PsiFile.relativePath #7238

Merged
merged 3 commits into from May 5, 2024
Merged

Remove PsiFile.relativePath #7238

merged 3 commits into from May 5, 2024

Conversation

3flex
Copy link
Member

@3flex 3flex commented Apr 28, 2024

No description provided.

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.77%. Comparing base (1c12968) to head (e2a3ff3).
Report is 2 commits behind head on main.

Files Patch % Lines
.../arturbosch/detekt/core/tooling/ParsingStrategy.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7238      +/-   ##
============================================
- Coverage     84.78%   84.77%   -0.01%     
  Complexity     3994     3994              
============================================
  Files           578      578              
  Lines         12136    12131       -5     
  Branches       2483     2483              
============================================
- Hits          10289    10284       -5     
  Misses          623      623              
  Partials       1224     1224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BraisGabin BraisGabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a great refactor 👏👏👏 (not only this PR, all this PR chain).

I'm approving to avoid blocking you but I think that my comment should be fixed. It should be really easy (github doesn't let me provide a suggestion 😭)

@3flex 3flex disabled auto-merge May 5, 2024 23:38
@3flex 3flex enabled auto-merge (squash) May 5, 2024 23:38
@3flex 3flex merged commit b01bc7a into detekt:main May 5, 2024
21 checks passed
@3flex 3flex deleted the location-4 branch May 5, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api breaking change Marker for breaking changes which should be highlighted in the changelog core parser psi-utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants