Ui::Animations::Simple: ensure .start() starts from from
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolayne
commented
Jan 1, 2025
kolayne
force-pushed
the
animations-fading-out
branch
from
073079b to
07b90e9
Compare
kolayne
changed the title
Ui::Animations::Simple: add .fadingOut() and fix .start()Ui::Animations::Simple: ensure .start() starts from from
kolayne
force-pushed
the
animations-fading-out
branch
from
07b90e9 to
1da57c5
Compare
Unlike the `.change()` method, which configures a running animation to go to a different state, the `.start()` method should first set the initial opacity value, then animate. It is fixed by making sure the private `.prepare()` method always sets `from`, rather than ignoring it when the animation is already running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the
.change()method, which configures a running animation togo to a different state, the
.start()method should first set theinitial opacity value, then animate.
It is fixed by making sure the private
.prepare()method always setsfrom, rather than ignoring it when the animation is already running.Part of a fix of telegramdesktop/tdesktop#28811.