[lfs] crossover: allow overriding bottles path via CX_BOTTLE_PATH #660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows overriding the default directory containing CrossOver bottles and used to launch games in bottles, which is also the same environment variable used by the wine executable from CrossOver once executed. Before these changes, the only supported directory for bottles is the default
~/Library/Application Support/CrossOver/Bottles
folder.Context
If we were to simply update the path Legendary uses to find bottles (without utilizing the
CX_BOTTLE_PATH
environment variable) based on e.g. some user configuration, then the CrossOver executable will fail to find the targeted bottle based on its invocation. Instead, this PR just utilizesCX_BOTTLE_PATH
for the override to kill two birds with one stone.Therefore, if desired, to allow this to be configurable via
~/.config/legendary/config.ini
, one would need to apply the environment variable when running CrossOver the same wayCX_BOTTLE
is done incore.py
/etcUsage
My bottles are stored on an external SD Card, since games are big and I don't need them available all the time. After these changes, I'm able to launch games with bottles stored in
/Volumes/Games/CrossOver
, for example/Volumes/Games/CrossOver/RocketLeague
, like so:Alternatively,
CX_BOTTLE_PATH
could be set in abash_profile
or similar.