This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
Fix sampleproject example #383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Before this change, the instructions with `sampleproject` would fail during the `dephell deps convert --from=setup.py --to=pyproject.toml` step with the error: > WARNING cannot find tool.dephell section in the config (path=pyproject.toml) ERROR NonExistentKey: 'Key "build-system" does not exist.' This is because the `HEAD` of `sampleproject` now includes a pyproject file with a section that causes the error above. - After this change, the sample project example works again because a commit hash from ~Nov 2019 is checked out where a pyproject hadn't been added to the `sampleproject` repo yet.
orsinium
suggested changes
Mar 11, 2020
There was a problem hiding this comment.
Thank you for your contribution! Let's make it a bit better and adopt for the changes. If you specify --to-format=poetry --to-path=pyproject.toml instead of --to=pyproject.toml it should work. Could you try and fix the example in this way instead, please?
Yeah, I definitely should make format inference smarter. I'll take care of this part ;)
UPD: if you'll do changes, merge the master into your branch, please. I've fixed CI a bit, it was broken a few weeks ago.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dephell deps convert --from=setup.py --to=pyproject.tomlstep with the error:This is because the
HEADofsampleproject's master branch now includes a pyproject file with a section that causes the error above.sampleprojectrepo yet.