Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handles build_num as comparable to year_month or year_month_day in docker tags #11207

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pluralistix
Copy link

What are you trying to accomplish?

docker images tagged with name:999 and name:1007 should be comparable. ATM they are not.

see #11198

Anything you want to highlight for special attention from reviewers?

I'm pretty certain, that this is the wrong way. The PR is more to illustrate the linked issue.

Checklist

  • [ ✅ ] I have run the complete test suite to ensure all tests and linters pass.
  • [ ✅ ] I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • [ ✅ ] I have written clear and descriptive commit messages.
  • [ ✅ ] I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • [ ❓ ] I have ensured that the code is well-documented and easy to understand.

@pluralistix pluralistix requested a review from a team as a code owner January 2, 2025 21:27
@github-actions github-actions bot added the L: docker Docker containers label Jan 2, 2025
@pluralistix pluralistix mentioned this pull request Jan 2, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: docker Docker containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant