Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting the correct requirement based on the given marker condition. #11204

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thavaahariharangit
Copy link
Contributor

What are you trying to accomplish?

Selecting the correct requirement based on the given marker condition.

Anything you want to highlight for special attention from reviewers?

When multiple requirements are present, the correct requirement should be selected based on the given marker condition.

How will you know you've accomplished your goal?

RSpec and Dependabot Cli Run

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@thavaahariharangit thavaahariharangit requested a review from a team as a code owner January 2, 2025 18:00

case operator
when "<"
Gem::Version.new(python_version) < Gem::Version.new(version)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use Gem::Version for this. Use Dependabot::Python::Version instead. You could run into some strange and nasty issues with these comparisons due to the Gem::Version spec being different from the Dependabot::Python::Version spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants