API-35477-526-sync-pdf-client

[stiehlrod]

Summary

• Adds error handling via the custom_error to the pdf_client

Related issue(s)

• API-36598

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

What areas of the site does it impact?

modified:   modules/claims_api/lib/custom_error.rb
modified:   modules/claims_api/lib/pdf_generator_service/pdf_client.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[rockwellwindsor-va]

@stiehlrod Is there an example request you have that would help with generating an Array with a 400 included in it?

[FonzMP]

easiest way I've replicated it is by violating a request type by setting @request_body in the pdf_client to be nil before sending. I think there are specifics for request body items as well. Probably worth uncovering one. I thought currentVaEmployee would trigger it but? even a blank object was succeeding.

Also, weird nuance to consider. Staging was returning a 400 via HTML and sandbox was returning a 400 w/ a detailed JSON response. Was pretty interesting. Not sure if they were in the middle of an upgrade? But if you experience issues may be worth trying both staging <> sandbox proxies to be safe.

[stiehlrod]

@rockwellwindsor-va use Postman: https://localhost:4451/form-526ez-pdf-generator/v1/openapi.json to find a 400 violation

[rockwellwindsor-va]

LGTM!