Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appointment search using VPG #16794

Merged
merged 1 commit into from
May 21, 2024
Merged

Appointment search using VPG #16794

merged 1 commit into from
May 21, 2024

Conversation

devin-mccurdy
Copy link
Contributor

@devin-mccurdy devin-mccurdy commented May 17, 2024

Summary

  • Changes are behind va_online_scheduling_enable_OH_reads feature flag
  • Appointment search requests are now sent to the vpg endpoint instead of vaos

Related issue(s)

https://app.zenhub.com/workspaces/appointments-oracle-health-integration-65a6e99ea522640e4d09393b/issues/gh/department-of-veterans-affairs/va.gov-team/83349

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

These changes impact health appointment creation.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution

Copy link

1 Error
🚫 This PR changes 524 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • modules/mobile/spec/request/appointments_vaos_v2_list_request_spec.rb (+420/-2)

  • modules/vaos/app/services/vaos/v2/appointments_service.rb (+20/-4)

  • modules/vaos/spec/services/v2/appointment_service_spec.rb (+78/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Copy link
Contributor

@drewconnelly drewconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but it appears that the size of the PR has tripped the LOC limit. I wonder if some of the tests could be added to a separate ticket.

@devin-mccurdy devin-mccurdy marked this pull request as ready for review May 20, 2024 12:59
@devin-mccurdy devin-mccurdy requested review from a team as code owners May 20, 2024 12:59
@devin-mccurdy devin-mccurdy marked this pull request as draft May 20, 2024 12:59
@drewconnelly drewconnelly marked this pull request as ready for review May 20, 2024 14:42
Copy link
Contributor

@aherzberg aherzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile changes look good to me. Are there any functional differences between VAOS and VPG?

@devin-mccurdy
Copy link
Contributor Author

Mobile changes look good to me. Are there any functional differences between VAOS and VPG?

No, for now VPG is using VAOS as the source

Copy link
Contributor

@aherzberg aherzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cferris32 cferris32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for VAOS

@devin-mccurdy devin-mccurdy merged commit c40e3a1 into master May 21, 2024
19 of 20 checks passed
@devin-mccurdy devin-mccurdy deleted the vpg-appointment-search branch May 21, 2024 19:55
ericboehs added a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants