Missing double-escaped quotes for installPath

demianmnave · Nov 19, 2024 · fad880c · fad880c
1 parent d30c74f
commit fad880c
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/.github/workflows/ninja-msvc17.yml b/.github/workflows/ninja-msvc17.yml
@@ -17,11 +17,8 @@ jobs:
           $vsinstaller = 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\vs_installer.exe'
           Test-Path -Path $vsinstaller | Should -Be $true
 
-          Start-Process -NoNewWindow -Wait -FilePath $vsinstaller `
-          -RedirectStandardOutput stdout.txt `
-          -RedirectStandardError stderr.txt `
-           -ArgumentList `
-            'modify', '--installPath', "$vspath", '--quiet', '--norestart', '--nocache', '--noUpdateInstaller', `
+          Start-Process -NoNewWindow -Wait -FilePath $vsinstaller -ArgumentList `
+            'modify', '--installPath', "`"$vspath`"", '--quiet', '--norestart', '--nocache', '--noUpdateInstaller', `
             '--add', 'Microsoft.VisualStudio.Component.VC.14.40.17.10.x86.x64'
 
           Get-ChildItem $env:LOCALAPPDATA\Temp\dd_installer_* | Get-Content