Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix cargo check for receive_emails benchmark #6305

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Dec 2, 2024

Replaces #6272

The only cargo invocation that would have caught this is cargo --all-features (without --workspace) because --workspace means that deltachat-repl is also compiled, which will enable the internals feature for the whole workspace. So, this is what I added to CI in the first commit.

The second commit fixes the problem.

@Hocuri Hocuri force-pushed the hoc/receive_emails-needs-internals branch from 89d1989 to 061f45e Compare December 2, 2024 20:34
@Hocuri Hocuri changed the title [WIP] ci: Also run cargo check without all-features ci: Also run cargo check without all-features Dec 2, 2024
@Hocuri Hocuri changed the title ci: Also run cargo check without all-features test: fix cargo check for receive_emails benchmark Dec 2, 2024
@Hocuri Hocuri merged commit 256b34d into main Dec 2, 2024
37 checks passed
@Hocuri Hocuri deleted the hoc/receive_emails-needs-internals branch December 2, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants