Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Rustls for connections with strict TLS #6186

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Nov 7, 2024

No description provided.

@link2xt
Copy link
Collaborator Author

link2xt commented Nov 7, 2024

This seems a bit dangerous as we previously had compatibility problems due to 1024-bit RSA:
#1007
However, the only known provider using 1024-bit RSA key is using self-signed certificate and has strict TLS disabled.
Valid TLS certificates should not use 1024-bit RSA since 2014: https://www.thawte.com/resources/2048-bit-compliance/
Even for root certificates 1024-bit RSA has been replaced: https://blog.mozilla.org/security/2014/09/08/phasing-out-certificates-with-1024-bit-rsa-keys/

There may be other compatibility problems that affect servers with valid TLS certificates, but they are likely to be treated as bugs in Rustls.

Advantage of this move is that Rustls supports modern TLS extensions such as ECH (https://www.memorysafety.org/blog/rustls-ech-support/), TLS session resumption and TLS certificate compression. I want to enable TLS session resumption soon after Rustls migration, this will have an immediate effect of reducing TLS connection setup by one round trip and reduction in computation costs of running DH: #6182
With native-tls it is unlikely that extensions will be implemented as it requires implementing the same API for OpenSSL, Schannel (Windows) and Security Framework (macOS): sfackler/rust-native-tls#308

@link2xt link2xt merged commit 3b2f18f into main Nov 7, 2024
37 checks passed
@link2xt link2xt deleted the link2xt/strict-rustls branch November 7, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants