Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compress backups with gzip #6111

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Oct 24, 2024

No description provided.

@link2xt link2xt changed the title feat: support importing gzip-compressed backups feat: compress backups with gzip Oct 25, 2024
@link2xt link2xt force-pushed the link2xt/backup-compression branch 4 times, most recently from db107d4 to f369a72 Compare October 25, 2024 01:08
@link2xt
Copy link
Collaborator Author

link2xt commented Oct 25, 2024

I exported backup with this and got backup file of 2775587230 bytes. Unpacked it is 3326787584 bytes, so saved 15%. Not very helpful because most blobs are not compressible, but still, 500 MB is not nothing. Did not measure how much slower it is with compression, but for backup export waiting a bit is fine. For over-the-network backup transfer it seems adding compression is not worth it.

zstd with default settings saved 50 MB more, so gzip is good enough and does not add additional dependencies. We already have the same compression for IMAP COMPRESS (gzip is deflate + some header and trailer).

@adbenitez
Copy link
Member

it seems adding compression is not worth it.

unless we allow to import over internet

@link2xt link2xt marked this pull request as draft December 3, 2024 00:13
@link2xt
Copy link
Collaborator Author

link2xt commented Dec 3, 2024

Let's wait until 1.50 releases are out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants