Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: markseen_msgs: Limit not yet downloaded messages state to InNoticed (#2970) #5999

Merged
merged 3 commits into from
Nov 20, 2024
Merged

fix: markseen_msgs: Limit not yet downloaded messages state to InNoticed (#2970) #5999

merged 3 commits into from
Nov 20, 2024

Commits on Nov 20, 2024

  1. test: Mark not downloaded message as seen (#2970) 

    Add a test on what happens currently when apps call `markseen_msgs()` for not downloaded encrypted
messages. Such messages are marked as seen, but MDNs aren't sent for them. Also currently when such
a message is downloaded, it remains `InSeen` despite the full content hasn't yet been seen by the
user.
    @iequidoo
    iequidoo committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ed4be83 View commit details
    Browse the repository at this point in the history

  2. fix: markseen_msgs: Limit not yet downloaded messages state to InNoti… 

    …ced (#2970)

This fixes sending MDNs for big messages when they are downloaded and really seen. Otherwise MDNs
are not sent for big encrypted messages because they "don't want MDN" until downloaded.
    @iequidoo
    iequidoo committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e9ee125 View commit details
    Browse the repository at this point in the history

  3. fix: Update state of message when fully downloading it 

    If a message partially downloaded before is already IMAP-seen upon a full download, it should be
updated to `InSeen`. OTOH if it's not IMAP-seen, but already `InNoticed` locally, its state should
be preserved. So we take the maximum of two states.
    @iequidoo
    iequidoo committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0aa5886 View commit details
    Browse the repository at this point in the history