[Spark] Add extra metrics for insert overwrite operation #4047
+133
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexvsalexvsalex
force-pushed
the
add_remove_metrics_for_insert_overwrite
branch
from
e190bb3 to
30e9df0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
When
INSERT OVERWRITEis used it deletes existing data and write new one. We have statistics about new wrote data, but it is unknown how much data we deleted.Changes in the PR suggests to enrich statistics by two extra metrics
numRemovedFilesandnumRemovedBytesto have basic understanding of deleted data.How was this patch tested?
Added new unit tests.
Does this PR introduce any user-facing changes?
New metrics
numRemovedFilesandnumRemovedByteswill appear in table's history for insert overwrite.If anybody wants to return back old behavior then they need to disable
spark.databricks.delta.insertOverwrite.removeMetrics.enabled.