[Kernel]Implement substring expression in delta kernel library #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huan233usc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Implements substring expression. This is 2/n for addressing #2539 (i.e. data skipping of startwith depends on substring expression, see[1] for spark's code pointer), the first part is implemented in #3991.
[1]https://github.com/delta-io/delta/blob/master/spark/src/main/scala/org/apache/spark/sql/delta/stats/DataSkippingReader.scala#L557-L561
How was this patch tested?
Added e2e test cases, the expected result are generated using spark, e.g.
WITH t(x) AS
(SELECT null union all select "one" union all select "two" union all select "three" union all select "four" union all select null union all select null union all select "seven" union all select "eight")
select substring(x,-100,98) from t
substring(x,-100,98)
null
o
t
thr
fo
null
null
sev
eig
Does this PR introduce any user-facing changes?
No