Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enableGravatar option to module #912

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

derekisbusy
Copy link
Contributor

Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Fixed issues comma-separated list of tickets # fixed by the PR, if any

@@ -66,9 +66,9 @@
)
); ?>

<?= $form
<?= ($this->context->module->enableGravatar)? $form
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use if.
Ternary not necessary here.

@thiagotalma
Copy link
Member

@derekisbusy Do you want to update your PR or should I close it?

@derekisbusy
Copy link
Contributor Author

@thiagotalma I updated the request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants