introduce $allowedIpConfiguration #902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ip configuration that determines if an administrator can log in. Defaults to null which means that no ip check is being performed.
thyseus
force-pushed
the
allowed-ips-for-administrator
branch
from
0fc6e2f
to
3bd0809
Compare
|
This would deny admins to login from unknown IPs, but not normal users. |
|
This is an security improvement headed towards administrator users. But you are right, i am thinking about an even more flexible solution: a column allowed_ips in the user table so that users can be restricted to ip range(s) very flexibly. What do you think? |
|
We need more opinions about this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ip configuration that determines if an administrator can log in.
Defaults to null which means that no ip check is being performed.