Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce allowImpersonateForRoles and denyImpersonateIntoRoles #1014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

introduce allowImpersonateForRoles and denyImpersonateIntoRoles #1014

wants to merge 1 commit into from

Conversation

thyseus
Copy link
Contributor

@thyseus thyseus commented Mar 1, 2018

Q A
Is bugfix? no
New feature? yes
Breaks BC? no
  • Security related improvements about impersonating

@thyseus thyseus mentioned this pull request Mar 1, 2018
Merged
@schmunk42
Copy link
Contributor

LGTM

@thyseus
Copy link
Contributor Author

thyseus commented Mar 2, 2018

Cool. Did not know LGTM yet. Looks great. But it says:

ERROR: Could not detect a suitable build command for the source checkout.

@schmunk42
Copy link
Contributor

ERROR: Could not detect a suitable build command for the source checkout.

I meant "Looks good to me" :) and you?

@thyseus
Copy link
Contributor Author

thyseus commented Mar 2, 2018

Hahahaha i thought you mean https://lgtm.com :)

Thanks for reviewing. I already use this code in my live environments, if you have any idea or suggestion, let me know.

@thiagotalma
Copy link
Member

I have good news.
@dmeroff has risen from the darkness and said that he will return to evaluate the PRs!

Let's wait for your word.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thyseus @schmunk42 @thiagotalma