Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#963 Update Gradle build mechanism to support Kotlin DSL with Gradle v6.3 #974

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#963 Update Gradle build mechanism to support Kotlin DSL with Gradle v6.3 #974

wants to merge 2 commits into from

Conversation

loxal
Copy link
Contributor

@loxal loxal commented Apr 20, 2020

  • provide specific & tested Gradle version to guarantee a working example
  • convert dynamically-typed Gradle script to statically-typed Kotlin DSL
  • update dependencies
  • cleanup imports

loxal added 2 commits April 20, 2020 05:04
@loxal
deeplearning4j#963 Update Gradle build mechanism to support Kotlin DS…
e6547cb 
…L with the latest Gradle v6.3

* provide specific & tested Gradle version to guarantee a working example
* convert dynamically-typed Gradle script to statically-typed Kotlin DSL
* update dependencies
* cleanup imports

Signed-off-by: Alex <[email protected]>
@loxal
Merge branch 'master' of github.com:eclipse/deeplearning4j-examples
20859d0
@saudet saudet requested a review from RobAltena April 20, 2020 03:15
RobAltena
RobAltena approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@RobAltena RobAltena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@saudet saudet requested a review from treo April 23, 2020 01:31
@loxal
Copy link
Contributor Author

loxal commented Apr 27, 2020

@treo are you going to merge this PR to master at some point?

@treo
Copy link
Member

treo commented Apr 27, 2020

There is a bigger example repository restructuring coming in a few days, in order to not loose this PR in the aftermath, I'm keeping it open to add it in afterwards and to make sure that the attribution doesn't get lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobAltena RobAltena RobAltena approved these changes

@treo treo Awaiting requested review from treo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loxal @treo @RobAltena