Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doc #218

Merged
merged 2 commits into from
May 21, 2024
Merged

fix doc #218

merged 2 commits into from
May 21, 2024

Conversation

matthieutrs
Copy link
Collaborator

@matthieutrs matthieutrs commented May 17, 2024 •
edited

Fix for #217 and minor doc issues

Checks to be done before submitting your PR

  • python3 -m pytest tests/ runs successfully.
  • black . runs successfully.
  • make html runs successfully (in the docs/ directory).
  • Updated docstrings related to the changes (as applicable).
  • Added an entry to the CHANGELOG.rst.

@tachella
Copy link
Contributor

Is this ready to merge?
Looks good to me

@matthieutrs matthieutrs marked this pull request as ready for review May 21, 2024 06:43
tachella
tachella approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@tachella tachella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the fixes look good to me

@tachella tachella merged commit 366eb3a into main May 21, 2024
4 checks passed
@tachella tachella mentioned this pull request May 21, 2024
Closed
@matthieutrs matthieutrs deleted the docs_fista branch May 21, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tachella tachella tachella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthieutrs @tachella