-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterator as fp #103
base: main
Are you sure you want to change the base?
Iterator as fp #103
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
- Coverage 76.01% 70.17% -5.85%
==========================================
Files 101 93 -8
Lines 7481 6715 -766
Branches 1013 904 -109
==========================================
- Hits 5687 4712 -975
- Misses 1474 1714 +240
+ Partials 320 289 -31 ☔ View full report in Codecov by Sentry. |
Major updates :
The dictionary iterated has typically the form {"iterate" : (x,z) , "estimate" : x, "cost" : F}.
The iterate variable can be either a tuple ( ADMM, CP), either a single tensor (all the other implemented iterators)
The link between the iterate and the estimate is given by the 'get_estiamte_from_iterate' function for each optim_iterator.
Minor updates :
Checks to be done before submitting your PR
python3 -m pytest tests/
runs successfully.black .
runs successfully.make html
runs successfully (in thedocs/
directory).