Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help message on conda environment creation error. Closes #1526 #1536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

umesh-timalsina
Copy link
Contributor

No description provided.

@umesh-timalsina umesh-timalsina changed the title Add help message on error. Closes #1526 Add help message on conda environement creation error. Closes #1526 Mar 19, 2020
@brollb brollb changed the title Add help message on conda environement creation error. Closes #1526 Add help message on conda environment creation error. Closes #1526 Mar 20, 2020
Copy link
Contributor

@brollb brollb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple main issues with this:

  • There is no check ensuring that the creation command failed because the environment already exists. For example, if conda isn't installed, this will still suggest running the command with --force which won't help at all. We could probably either check the error message or the exit code. I am not sure that the exit code will be very precise or cross platform.
  • As a minor point, it is already logged that the command failed so we can probably just remove that so we aren't repeating ourselves in the logs.
  • We should not use __dirname in the logs as this will print weird paths. For example, if we install deepforge with nvm, this will print a long path like /home/brian/.nvm/versions/node/v12.14.1/bin/browserify. This is not likely the path the user used to run the command so it's a bit strange. It's easier just to avoid this and suggest adding the '--force' flag to overwrite any existing environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants