Final merge PR for drand/kyber #512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added index of signature
returning err only if not enough valid partials
CluEleSsUK
reviewed
May 23, 2024
CluEleSsUK
reviewed
May 23, 2024
CluEleSsUK
reviewed
May 23, 2024
CluEleSsUK
reviewed
May 23, 2024
CluEleSsUK
reviewed
May 23, 2024
CluEleSsUK
reviewed
May 23, 2024
CluEleSsUK
reviewed
May 23, 2024
CluEleSsUK
reviewed
May 23, 2024
CluEleSsUK
reviewed
May 23, 2024
| } | ||
| // DST_prime = DST || I2OSP(len(DST), 1) | ||
| // b_0 = H(Z_pad || msg || l_i_b_str || I2OSP(0, 1) || DST_prime) | ||
| _, _ = h.Write(make([]byte, h.BlockSize())) |
There was a problem hiding this comment.
in the gnarkExpandMsgXmd we check/return errors but here we don't. Is there a reason to swallow them here? Admittedly they're unlikely to happen, but it seems like good hygiene
There was a problem hiding this comment.
The HashablePoint.Hash doesn't have an error in its return, I tried to handle the errors but the cascading effect goes out of hand. This pr might not be the place to do that ?
CluEleSsUK
reviewed
May 23, 2024
CluEleSsUK
reviewed
May 23, 2024
CluEleSsUK
reviewed
May 23, 2024
pairing/circl_bls12381/adapter.go
Outdated
| // still preserves the properties of the pairing (e.g. the Pair function). | ||
| // | ||
| // It's important to note that the Point function will generate a point | ||
| // compatible with public keys only (group G2) where the signature must be |
There was a problem hiding this comment.
is this not the reverse of the standard case? It seems that most bls libs put pub keys on G1 and sigs on G2. In drand we do the opposite.
It seems circl supports both
* Moved scheme.go and threshold.go into internals and uncommented bls_test.go * Removed nerr++ in favor of len(errors) * Changed the path for test * Sorting imports * Update bn256 from cloudflare's changes * Added the bn256/hash.go and its tests
* Removed nonce from Rabin VSS * Removed nonce from Pedersen VSS
* Switched back to matrix in CI * Fixed go version * Rm not working manual go version for alpine * Removed debugging + fixed go version on x86 + go version to 1.21-1.22 * Unified test workflow * Upgrade go version + rm matrix from permission * Added concurrency check back
* BREAKING API change: Refactored curve packages nist -> p256 * BREAKING API change: Changed names from 25519 to ed25519 --------- Co-authored-by: Yolan Romailler <[email protected]>
* Add rfc9380 test vectors * Add expand_message_xmd * Add test vector sha512 * Add Elligator2 for curve25519 * Add mapToCurve for edwards25519 * Add domain separator as param * Set to use sha512 by default * Extract repeated inputs in test * Add test * Use proper byte to fe * Use constant fe computed manually * Add test hashToField * Pad array * Add Hash() test * Add doc for new fe functions * Add inline operations comments * Add rfc ref * Add fe conversion test * Add long dst support + tests * Add missing mod * Add expandMessageXOF * Add readme with code for test vector gen. * Add test vector + more complex property test * Force use of domain separator * Add domainSep. check expand xof --------- Co-authored-by: Yolan Romailler <[email protected]>
* Added circl and kilic implementation of bls12381 + benchmarks * Added deserialization tests compressed vectors +more comments * Fix IBE in the drand merge (#514) * Add ByteOrder() function + constant from int.go * Update circl_bls12381 and edwards25519 scalars * Add Order() to the scalar interface * Adapt IBE to make it general * Fix dkg bug (#515) * BugFix: use array index instead of node index * Fix endianess bool * Add tests for endianess * Fixed deserialization tests + circl issue * Removed groupchecker iface * Added back circl deserialization test (cloudflare/circl#499) * Since Go 1.21 go mod tidy require the go directive to match the highest of our dependencies --------- Co-authored-by: Kilian <[email protected]> Co-authored-by: Yolan Romailler <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new PR for #509 to allow everyone to work against the
drandmergebranch on the Dedis repo.