Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode request data as JSON when Content-Type is set to application/json #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/reqwest.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,22 @@
var o = this.o
, method = (o['method'] || 'GET').toUpperCase()
, url = typeof o === 'string' ? o : o['url']
// convert non-string objects to query-string form unless o['processData'] is false
, data = (o['processData'] !== false && o['data'] && typeof o['data'] !== 'string')
? reqwest.toQueryString(o['data'])
: (o['data'] || null)
, http
, sendWait = false
, sendWait = false;

// convert JSON objects to JSON strings when contentType is application/json
// and other non-string objects to query-string form unless o['processData']
// is false
var data = null;
if (o['processData'] !== false && o['data']) {
if (o['contentType'] === 'application/json' && typeof o['data'] === 'object') {
data = JSON.stringify(o['data']);
} else if (typeof o['data'] !== 'string')) {
data = reqwest.toQueryString(o['data']);
} else {
data = o['data'];
}
}

// if we're working on a GET request and we have data then we should append
// query string to end of URL and not post data
Expand Down