Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISSUE and PULL REQUEST template #104

Merged
merged 2 commits into from
Jun 3, 2023
Merged

Conversation

ramsayleung
Copy link
Contributor

@ramsayleung ramsayleung commented Jun 2, 2023

Description

  1. 增加 ISSUE 与 PULL REQUEST TEMPLATE, 方便协作者提供上下文信息
  2. 修复错误注释

Motivation and Context

提供模板供开发者提ISSUE 或PR, 统一规范与流程.

New Issue -> Choose Template:

image

New Pull Request:

image

Dependencies

None

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

All CI jobs pass

Is this change properly documented?

It's unnecessary

@ramsayleung ramsayleung changed the title 修复错误注释 增加 ISSUE 与 PULL REQUEST 模板 Jun 2, 2023
Copy link
Member

@Triple-Z Triple-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But it seems the CI failed.

@ramsayleung
Copy link
Contributor Author

ramsayleung commented Jun 2, 2023

It's a little weird, since I only modify the comment and add three new markdown files, the CI should pass.

  Running [/home/runner/golangci-lint-1.53.0-linux-amd64/golangci-lint run --out-format=github-actions --timeout=5m] in [] ...
  level=error msg="[linter] depguard: create analyzer: couldn't expand $gostd: could not read GOROOT directory: open src: no such file or directory\nmust have an Allow and/or Deny package list"
  
  Error: golangci-lint exit with code 3

PS: I think I figure out the root cause, it is golangcli-lint :

@ramsayleung ramsayleung changed the title 增加 ISSUE 与 PULL REQUEST 模板 Add ISSUE and PULL REQUEST template Jun 2, 2023
Copy link
Member

@Triple-Z Triple-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Triple-Z Triple-Z merged commit 35bc977 into master Jun 3, 2023
@gaocegege gaocegege deleted the ramsay/add_td_provider branch November 13, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants