Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about gitignoring xhgui files #9

Closed
wants to merge 1 commit into from
Closed

Add note about gitignoring xhgui files #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ This addon is designed to add the XHGui service to a project served by DDEV.
This addon is intended for debugging in a development environment.
Profiling in a production environment is not recommend.

It's therefore wise to add `xhgui.collector.php` and `xhgui.collector.config.php` to your `.gitignore` so it won't accidentally deploy to your production website.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my review in #5 - we don't even need to copy those in, we can use them directly. So this suggestion would be obsolete.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I'll close this PR.


## Getting started

- Install the `ddev-xhgui` add-on:
Expand Down