Add optional --redis-tag flag, fixes #1
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasadev
force-pushed
the
20240717_stasadev_optional_version
branch
from
ab6497b
to
79facaa
Compare
|
Please take a look and make ready for review when ready, thanks. |
|
Sure, but first I need to finish the parent task and it should probably be ready next week. |
stasadev
changed the title
stasadev
changed the title
--redis-tag flag, fixes #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
ddev add-on getshould allow specifying optional settings ddev#4430How This PR Solves The Issue
Adds optional
--redis-tag valueflag, that creates.ddev/.env.redisfile withREDIS_TAG="value".Manual Testing Instructions
Install add-on using DDEV binary from:
ddev add-on get, fixes #4430 ddev#6406Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes