Add removal_action to remove settings.ddev.redis.php on add-on removal #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually tested with v1.21.6 and v1.22.0, all seems to work correctly. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
In DDEV v1.22.0+ there is a
removal_actionssection of the install.yaml, specifically for things like what this add-on does, adding settings config into sites/default.How This PR Solves The Issue
Do the cleanup of sites/default/settings.ddev.redis.php on removal
Manual Testing Instructions
On a drupal site:
ddev get https://github.com/rfay/ddev-redis/tarball/20230720_post_removal_actionVerify that sites/default/settings.ddev.redis.php exists
ddev get --remove redisYou should have no sites/default/settings.ddev.redis.php any more.
Make sure it doesn't break on DDEV v1.22.6 (which should ignore that extra section)
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes