Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ddev phpmyadmin for Gitpod #21

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Oct 3, 2024

The Issue

The ddev phpmyadmin command can open a blank page in preview mode, open the link in a new browser tab/window to make it work.

How This PR Solves The Issue

Uses xdg-open for PhpMyAdmin URL.

Manual Testing Instructions

In Gitpod:

https://ddev.github.io/ddev-gitpod-launcher/

ddev get https://github.com/ddev/ddev-phpmyadmin/tarball/20241003_stasadev_fix_gitpod_command
ddev restart
ddev phpmyadmin

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev requested a review from rfay October 3, 2024 19:55
@stasadev stasadev force-pushed the 20241003_stasadev_fix_gitpod_command branch from 5c3381d to 217701b Compare October 3, 2024 19:56
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Tested on gitpod and on WSL2.

@rfay rfay merged commit dcdd0fc into main Oct 3, 2024
2 checks passed
@rfay rfay deleted the 20241003_stasadev_fix_gitpod_command branch October 3, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants