fix: make ddev phpmyadmin
work again for Gitpod, fixes #15
#16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
ddev phpmyadmin
doesn't work in Gitpod #15How This PR Solves The Issue
Fixes the condition to open the correct port (I chose not to change the forwarded port from
8036
to8037
in thedocker-compose.phpmyadmin-norouter.yaml
file because we only "use" HTTP ports in the cloud and it would be confusing if we forwarded the HTTPS port).Adds a tip about preview mode in Gitpod.
Renames
docker-compose.phpmyadmin-norouter.yaml
todocker-compose.phpmyadmin_norouter.yaml
Manual Testing Instructions
Test with Gitpod on DDEV HEAD:
No need to test it with Codespaces because it won't work anyway, I see we don't omit
ddev-router
in Codespaces, it's in my TODOs.Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes