Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rebasing #25 I saw that the CI tests are broken.
This happened due to a change in the version of
select-dom
, which for some reason doesn't work nicely withts-jest
.github-vscode-icons/package.json
Line 64 in ee4a667
Also for the page selector tests to not fail kinda randomly (connection timeout), I raised the max timeout limit for rendering the pages from 5s (jest default) to 30s.
That way the scheduled tests shouldn't span you due to connection timeouts that often (hopefully no false positives at all anymore).