Added firefox web_ext_id to firefox manifest creation script

and removed it from it from the workflow see web-ext 5 release notes: https://github.com/mozilla/web-ext/releases/tag/5.0.0
dderevjanik · Oct 15, 2020 · f2dd3b6 · f2dd3b6
1 parent 4263aa4
commit f2dd3b6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -114,7 +114,6 @@ jobs:
  path: dist
  - name: Upload to firefox store
  env:
- WEB_EXT_ID: ${{ secrets.WEB_EXT_ID }}
  WEB_EXT_API_KEY: ${{ secrets.WEB_EXT_API_KEY }}
  WEB_EXT_API_SECRET: ${{ secrets.WEB_EXT_API_SECRET }}
  run: |

diff --git a/packages/ManifesFirefox.ts b/packages/ManifesFirefox.ts
@@ -4,5 +4,13 @@ export const createFirefoxManifest = () => {
  const manifest = createChromeManifest();
  delete manifest['offline_enabled'];
  delete manifest['background']['persistent'];
- return manifest;
+ const fireFoxSpecifficSettings = {
+ browser_specific_settings: {
+ gecko: {
+ id: '{dd10a870-27c8-4b74-bfd4-0f767fe68770}',
+ strict_min_version: '67.0'
+ }
+ }
+ };
+ return { ...manifest, ...fireFoxSpecifficSettings };
 };