Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support tagging friends on tastings #57

Merged
merged 1 commit into from Sep 12, 2023
Merged

Conversation

dcramer
Copy link
Owner

@dcramer dcramer commented Sep 12, 2023

This does not do anything with the data other than record it and return it via the API.

Will follow up with:

  1. showing whos tagged
  2. notifications when you're tagged

Refs #10

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.20% ⚠️

Comparison is base (fb94a22) 84.02% compared to head (b3b6237) 83.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   84.02%   83.82%   -0.20%     
==========================================
  Files         126      126              
  Lines        9951     9995      +44     
  Branches      844      847       +3     
==========================================
+ Hits         8361     8378      +17     
- Misses       1590     1617      +27     
Files Changed Coverage Δ
apps/api/src/routes/addTasting.ts 72.63% <18.18%> (-7.26%) ⬇️
apps/api/src/lib/serializers/tasting.ts 91.89% <52.63%> (-8.11%) ⬇️
apps/api/src/db/schema/tastings.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcramer dcramer merged commit 495076e into main Sep 12, 2023
1 of 3 checks passed
@dcramer dcramer deleted the feat/tasting-friends branch September 12, 2023 10:56
@dcramer dcramer restored the feat/tasting-friends branch September 12, 2023 10:56
@dcramer dcramer deleted the feat/tasting-friends branch September 12, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant