Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Sentry trace continuation API #164

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Switch to Sentry trace continuation API #164

merged 1 commit into from
Apr 24, 2024

Conversation

dcramer
Copy link
Owner

@dcramer dcramer commented Apr 24, 2024

No description provided.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 8.47458% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 77.76%. Comparing base (cc0300b) to head (c6dc5b5).

❗ Current head c6dc5b5 differs from pull request most recent head 2f192a2. Consider uploading reports for the commit 2f192a2 to get more accurate results

✅ All tests successful. No failed tests found ☺️

Files Patch % Lines
apps/server/src/jobs/client.ts 8.47% 54 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   77.73%   77.76%   +0.02%     
==========================================
  Files         198      198              
  Lines       14573    14574       +1     
  Branches     1233     1233              
==========================================
+ Hits        11329    11334       +5     
+ Misses       3244     3240       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcramer dcramer changed the title Draft code to fix trace propagation Switch to Sentry trace continuation API Apr 24, 2024
@dcramer
Copy link
Owner Author

dcramer commented Apr 24, 2024

This appears to be working, but need to yet validate that in a typical async job (e.g. a cron job) its isolating trace IDs.

@dcramer dcramer enabled auto-merge (squash) April 24, 2024 16:28
@dcramer dcramer disabled auto-merge April 24, 2024 16:28
@dcramer dcramer enabled auto-merge (squash) April 24, 2024 16:28
@dcramer dcramer merged commit f980daa into main Apr 24, 2024
3 checks passed
@dcramer dcramer deleted the fix/traces branch April 24, 2024 16:29
@dcramer
Copy link
Owner Author

dcramer commented Apr 24, 2024

Need to verify the otel implementation previously worked and that the SDK changes wont break someone having manually instrumented their own trace continuation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant