create separate config instance and change max pool configuration #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the API Client setup to separate out configuration enabling us to change the connection_pool_maxsize. This parameter defaults to 100 in the Luxor API. Given these are little micro-controllers on a landscape lighting controller, this appears to be causing disconnects when too many api calls are made.
Per the Luxor Open API documents, setting this to a small value will queue the requests and send them automatically so this setting should be safe. I've tested this with multiple groups being changed at the same time by adding those Luxor groups to a card, changing the on/off toggle in the header of the home-assistant card and it appears things are updating and working properly.
This Closes #10