Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uni-components): 修复ResizeSensor组件rootRef.value可能为空的bug (close #4874) #4875

Merged
merged 1 commit into from May 11, 2024
Merged

fix(uni-components): 修复ResizeSensor组件rootRef.value可能为空的bug (close #4874) #4875

merged 1 commit into from May 11, 2024

Conversation

31702160323
Copy link
Contributor

@Otto-J
Copy link
Member

Otto-J commented Apr 29, 2024

感谢你的 PR，可以在此 PR 或者关联 issues 中提供复现工程说明问题吗？比如复现工程、操作步骤、涉及的平台等等，提供这些信息可以让对应的人能更快定位和测试你的问题。

@31702160323
Copy link
Contributor Author

31702160323 commented Apr 30, 2024 •
edited by Otto-J

@Otto-J 这个问题我也无法百分比复现，但是这个问题很早就存在了，加上这个问题并不会影响运行，所以一直没管它。错误信息可以看#4874这个链接。

1714442565806

@Otto-J
Copy link
Member

Otto-J commented May 11, 2024

感谢你的反馈，我和同事阅读了这部分代码，对 ref 的引用是个对象，返回的 update 都是在 onMounted 之后才执行的，按理说不会产生问题。我们先按照你的改动合并代码，也欢迎提供更多测试场景来验证你的改动。

祝贺成为 First-time contributor，也欢迎更多参与 uniapp 开源贡献

@Otto-J Otto-J self-requested a review May 11, 2024 10:10
@Otto-J Otto-J merged commit f419cc3 into dcloudio:next May 11, 2024
0 of 4 checks passed
@Otto-J
Copy link
Member

Otto-J commented May 11, 2024

代码已合并

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Otto-J Otto-J Otto-J approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@31702160323 @Otto-J